fix: reject non-array needs with clear error - #1863
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
A null array element (e.g. `needs: [~]` or a dangling list dash) crashed with `TypeError: null is not an object` in needsComplex. Assert each entry is non-null so it produces a helpful message instead.
|
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jul 9, 2026
This MR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Adoption](https://docs.renovatebot.com/merge-confidence/) | [Passing](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---|---|---| | [npm:gitlab-ci-local](https://github.com/firecow/gitlab-ci-local) | `4.72.0` → `4.73.0` |  |  |  |  | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>firecow/gitlab-ci-local (npm:gitlab-ci-local)</summary> ### [`v4.73.0`](https://github.com/firecow/gitlab-ci-local/releases/tag/4.73.0) [Compare Source](firecow/gitlab-ci-local@4.72.0...4.73.0) #### What's Changed - fix: prevent ENAMETOOLONG crash for long parallel:matrix job names by [@​gyanranjan](https://github.com/gyanranjan) in [#​1865](firecow/gitlab-ci-local#1865) - fix: reject non-array needs with clear error by [@​firecow](https://github.com/firecow) in [#​1863](firecow/gitlab-ci-local#1863) - A support for GPU by [@​zapadinsky](https://github.com/zapadinsky) in [#​1866](firecow/gitlab-ci-local#1866) - fix: validate spec:inputs:regex instead of logging a no-op warning by [@​ApoorvaMohan](https://github.com/ApoorvaMohan) in [#​1869](firecow/gitlab-ci-local#1869) - feat: support image.docker.platform by [@​inistor](https://github.com/inistor) in [#​1856](firecow/gitlab-ci-local#1856) - Allow to use `component.reference`, `component.sha`, `component.version` and `component.name` by [@​jrd](https://github.com/jrd) in [#​1836](firecow/gitlab-ci-local#1836) #### New Contributors - [@​zapadinsky](https://github.com/zapadinsky) made their first contribution in [#​1866](firecow/gitlab-ci-local#1866) - [@​ApoorvaMohan](https://github.com/ApoorvaMohan) made their first contribution in [#​1869](firecow/gitlab-ci-local#1869) - [@​jrd](https://github.com/jrd) made their first contribution in [#​1836](firecow/gitlab-ci-local#1836) **Full Changelog**: <firecow/gitlab-ci-local@4.72.0...4.73.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTYuMCIsInVwZGF0ZWRJblZlciI6IjQzLjI1Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
needs: build(scalar string instead of a list) crashed withTypeError: Attempted to assign to readonly propertyinneedsEachbecauseObject.entriesiterated the string's characters and assignment to string indices is read-only.needsis an array up front, matching the upstream GitLab schema (top-levelneedsis"type": "array").Test plan
bunx vitest run tests/test-cases/needs-not-array/passesneeds-*tests still passSummary by cubic
Reject non-array and empty job
needswith clear errors. Prevents crashes and aligns with GitLab’s array schema.needsinneedsEach; add test for stringneeds.needsentries; add test forneeds: [~].Written for commit 4648adc. Summary will update on new commits.